Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add aten::index_reduce operator #1156

Merged
merged 27 commits into from
Jan 9, 2025
Merged

Add aten::index_reduce operator #1156

merged 27 commits into from
Jan 9, 2025

Conversation

cfgfung
Copy link
Contributor

@cfgfung cfgfung commented Dec 11, 2024

  • index_reduce.out
  • index_reduce
  • index_reduce_

@cfgfung
Copy link
Contributor Author

cfgfung commented Dec 19, 2024

Synced with @xytintel , the difference is small. Will skip those 3 cases.

e.g:
Mismatched elements: 1 / 60 (1.7%)
Greatest absolute difference: 0.0625 at index (2, 1, 4) (up to 1e-05 allowed)
Greatest relative difference: 0.001125335693359375 at index (2, 1, 4) (up to 0.001 allowed)

@cfgfung cfgfung requested a review from xytintel December 19, 2024 01:47
@xytintel xytintel added the xpu-op label Jan 3, 2025
@xytintel
Copy link
Contributor

xytintel commented Jan 9, 2025

Implemented the index_reduce, index_reduce_ and index_reduce.out operators.

It passes most of the unit tests on the PVC platform except 3 tests. Those failed tests are bf16 and float16.

image

I checked the differences and found those are small. For example:

Mismatched elements: 1 / 60 (1.7%)
Greatest absolute difference: 0.0625 at index (2, 1, 4) (up to 1e-05 allowed)
Greatest relative difference: 0.001125335693359375 at index (2, 1, 4) (up to 0.001 allowed)

To execute this test, run the following from the base repo dir:
python test/xpu/test_torch_xpu.py
TestTorchDeviceTypeXPU.test_index_reduce_reduce_prod_xpu_float16

I suspect the software emulation of the atomic operations of those low-level precisions causes that. Shall we skip those tests?

Need inputs from @xytintel and @fengyuan14

Side note: This function is in beta and may change in the near future. (Ref - https://pytorch.org/docs/stable/generated/torch.Tensor.index_reduce_.html)

@xytintel xytintel added this pull request to the merge queue Jan 9, 2025
Merged via the queue into main with commit 8988335 Jan 9, 2025
4 checks passed
@xytintel xytintel deleted the reduce_index_v2 branch January 9, 2025 14:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants